[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17852 )
Change subject: [ntp] improve two arithmetic operator ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17852/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17852/1//COMMIT_MSG@7 PS1, Line 7: imp > It's kind of 'improve' or 'optimize', not 'fix' ok, already change the message http://gerrit.cloudera.org:8080/#/c/17852/1/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/17852/1/src/kudu/clock/hybrid_clock.cc@587 PS1, Line 587: poll_backoff_ms << 1 > I'm not sure this brings any optimization: I guess the compiler is smart en Yes, you are right. g++ has optimized it. -- To view, visit http://gerrit.cloudera.org:8080/17852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5775d9206e82dfd1febd98219dbde1bb69a44240 Gerrit-Change-Number: 17852 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 27 Sep 2021 08:39:17 +0000 Gerrit-HasComments: Yes
