Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/17852 )
Change subject: [ntp] improve two arithmetic operator ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17852/3/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/17852/3/src/kudu/clock/hybrid_clock.cc@587 PS3, Line 587: poll_backoff_ms = std::min(poll_backoff_ms << 1, 1000); No big deal, considering it's already merged, but in general I think these kinds of changes are not improvements: - as you pointed out, every compiler out there already makes such optimizations when it's safe to do so - in this case, it's logically supposed to be "doubling", not a bitwise pattern that we're trying to express - this isn't a hot path, so even if it were a valid micro-optimization, it wouldn't matter. -- To view, visit http://gerrit.cloudera.org:8080/17852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5775d9206e82dfd1febd98219dbde1bb69a44240 Gerrit-Change-Number: 17852 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 16:46:48 +0000 Gerrit-HasComments: Yes
