Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )
Change subject: [master] Expose error when set an unsupported table extra config ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc@673 PS1, Line 673: set Nit: could be unordered_set http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc@697 PS1, Line 697: __builtin_unreachable(); Is this still needed with LOG(FATAL)? -- To view, visit http://gerrit.cloudera.org:8080/17914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9 Gerrit-Change-Number: 17914 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Oct 2021 19:09:44 +0000 Gerrit-HasComments: Yes
