Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )
Change subject: [master] Validate extra config properties for a table ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@7 PS2, Line 7: Validate extra config properties for a table > How about: Done http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@9 PS2, Line 9: Prior to this patch, no validation was performed on the strings : representing the keys of extra configuration properties for a : table. : This patch adds the missing validation logic, so now an error : is returned on attempt to set unsupp > How about: Done http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc@4787 PS2, Line 4787: ASSERT_TRUE(s.IsInvalidArgument()) > nit: when an assertion like this triggers, it's easier to debug if the info Done -- To view, visit http://gerrit.cloudera.org:8080/17914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9 Gerrit-Change-Number: 17914 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 05:50:03 +0000 Gerrit-HasComments: Yes
