Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )
Change subject: [master] Expose error when set an unsupported table extra config ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@7 PS2, Line 7: Expose error when set an unsupported table extra config How about: validate extra config properties for a table http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@9 PS2, Line 9: Now table extra configs are set by strings, there is not check on : both client and server sides, a typo is easy happened without any : warnings. : This patch adds a check, an error be returned if setting an : unsupported extra config to a table. How about: Prior to this patch, no validation was performed on the strings representing the keys of extra configuration properties for a table. This patch adds the missing validation logic, so now an error is returned on attempt to set unsupported extra configuration properties for a table. http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc@4787 PS2, Line 4787: ASSERT_TRUE(s.IsInvalidArgument()); nit: when an assertion like this triggers, it's easier to debug if the information on the actual status is output as well ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString(); -- To view, visit http://gerrit.cloudera.org:8080/17914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9 Gerrit-Change-Number: 17914 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 04:20:36 +0000 Gerrit-HasComments: Yes
