Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/17942 )
Change subject: [LBM] Speed up server bootstrap by using multi-thread to compact containers ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2106 PS2, Line 2106: .set_max_threads(dd_manager_->dirs().size()) how large can dd_manager_->dirs().size() get in production and shouldn't we have some sort of a safety limit here to avoid opening too many threads? http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2977 PS2, Line 2977: first_fatal_error = s.CloneAndPrepend( Is first_fatal_error always guaranteed to contain the first encountered error? Can it be overwritten by subsequent errors in other threads? http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2992 PS2, Line 2992: LOG_AND_RETURN(WARNING, first_fatal_error); perhaps, it would be beneficial to aggregate errors and log all errors, if there were multiple. -- To view, visit http://gerrit.cloudera.org:8080/17942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie48211d9e8c1d74e520fcb04df25c1d681261bb5 Gerrit-Change-Number: 17942 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Oct 2021 21:18:26 +0000 Gerrit-HasComments: Yes
