Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17942 )

Change subject: [LBM] Speed up server bootstrap by using multi-thread to 
compact containers
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2151
PS2, Line 2151:     container_result->need_repunching_blocks.end());
> Instead of submitting a task to submit another task on a dir's thread pool,
1. In LogBlockManager::Repair, we will wait all metadata compact workers 
complete, then synchronous execute following tasks (check whether directory 
load success, logging...), but it's impossible to wait in the thread pool for 
other threads complete in the same pool.
2. :( I'm sorry I didn't get your point, could you please explain more or give 
some simple pseudo code, thanks.



--
To view, visit http://gerrit.cloudera.org:8080/17942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48211d9e8c1d74e520fcb04df25c1d681261bb5
Gerrit-Change-Number: 17942
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Greg Solovyev <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Sat, 30 Oct 2021 04:55:20 +0000
Gerrit-HasComments: Yes

Reply via email to