Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17942 )
Change subject: [LBM] Speed up server bootstrap by using multi-thread to compact containers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2151 PS2, Line 2151: CHECK_OK(repair_pool->Submit([this, dd_raw, dr]() { this->RepairTask(dd_raw, dr); })); Instead of submitting a task to submit another task on a dir's thread pool, maybe it makes more sense to simply increase the max_queue_size() for the directory's thread pool? An alternative approach might be getting rid of synchronous execution in this loop, only submitting a task on the directory's thread pool if it can accept one, and looping over the rest of directories whose thread pool is busy until all tasks have been scheduled. It quick and dirty approach, I guess it might be acceptable to use short sleep between the cycles if it's not possible to wait on the condition waiting for at least one dir's pool to become available. -- To view, visit http://gerrit.cloudera.org:8080/17942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie48211d9e8c1d74e520fcb04df25c1d681261bb5 Gerrit-Change-Number: 17942 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 25 Oct 2021 23:18:08 +0000 Gerrit-HasComments: Yes
