Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )
Change subject: [KUDU-3330] Define operator<< for MonoTime ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17961/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17961/1//COMMIT_MSG@7 PS1, Line 7: ] Will drop the parenthesis in the next revision of this patch. http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc File src/kudu/util/monotime.cc: http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc@355 PS1, Line 355: os << ts.tv_nsec; > Do we need a suffix that suggests this timestamp is in nanoseconds like "ns Done -- To view, visit http://gerrit.cloudera.org:8080/17961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769 Gerrit-Change-Number: 17961 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 22 Oct 2021 16:08:44 +0000 Gerrit-HasComments: Yes
