Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )
Change subject: KUDU-3330 Define operator<< for MonoTime ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc File src/kudu/util/monotime.cc: http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc@355 PS1, Line 355: os_ns << ts.tv_ns > Oh meant in the output of the ostringstream and not in the naming of the va Yep, I guess it makes sense to keep the name of the parameter as 'os' at least to keep it in sync between the header and this file. -- To view, visit http://gerrit.cloudera.org:8080/17961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769 Gerrit-Change-Number: 17961 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 22 Oct 2021 23:59:08 +0000 Gerrit-HasComments: Yes
