Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )
Change subject: KUDU-3330 Define operator<< for MonoTime ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h File src/kudu/util/monotime.h: http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@499 PS2, Line 499: An ostream object which will store the nanoseconds of MonoTime. how about: An ostream output object. http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@501 PS2, Line 501: A MonoTime object which has to be converted to ostream. how about: A MonoTime object to output. http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@503 PS2, Line 503: , time nit: drop this? http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.h File src/kudu/util/monotime.h: http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.h@493 PS1, Line 493: : /// @name Syntactic sugar: ostream operator for MonoTime. : ///@{ Since that's not a part of public API (no KUDU_EXPORT), it makes sense to annotate this method as private so it's not shown in the auto-generated docs. See https://github.com/apache/kudu/blob/0ade8c6f21f0887e90b261ae6b1a57f4a6d1eff1/src/kudu/client/client.h#L1045-L1052 for an example how to annotate this fact. I guess it's worth removing that 'Syntactic sugar' scope and replace it with the PRIVATE_API doxygen conditional. -- To view, visit http://gerrit.cloudera.org:8080/17961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769 Gerrit-Change-Number: 17961 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 22 Oct 2021 16:45:50 +0000 Gerrit-HasComments: Yes
