Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17962 )
Change subject: KUDU-3308: Add health check endpoint to webserver ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG@9 PS1, Line 9: This change adds a '/healthz' endpoint to the kudu-master and : tablet-server webinterfaces. It would be great if you added a small test for the newly introduced end-point. I guess WebserverTest.TestDefaultPaths is a good place (or a good reference) for such a new test scenario. http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG@12 PS1, Line 12: As the Webserver only starts after the RPC : Server has been started there is no need to add an initial wait time for : the first check I guess this is no longer true since https://github.com/apache/kudu/commit/bd5f72e0ed03b614d49b8125160bf555d11dcf9c is committed. http://gerrit.cloudera.org:8080/#/c/17962/1/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/17962/1/src/kudu/server/default_path_handlers.cc@452 PS1, Line 452: healthz Any specific consideration on using 'healthz' instead of just 'health'? From my experience, usually that's '/health' endpoint. -- To view, visit http://gerrit.cloudera.org:8080/17962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic735e210d95aeec1dfd1335ee972318f12d52475 Gerrit-Change-Number: 17962 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Oct 2021 20:28:57 +0000 Gerrit-HasComments: Yes
