Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17962 )
Change subject: KUDU-3308: Add health check endpoint to webserver ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG@12 PS1, Line 12: As the Webserver only starts after the RPC : Server has been started there is no need to add an initial wait time for : the first check > Yes, based on the commit msg there, moving it to "AddPostInitializedDefault Makes sense, indeed. http://gerrit.cloudera.org:8080/#/c/17962/1/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/17962/1/src/kudu/server/default_path_handlers.cc@452 PS1, Line 452: is_styl > What Attila said, and also the jira called for /healthz, but I'm fine with I'm OK with both as well, actually. I guess using those 'z' suffixes follows google's conventions: https://stackoverflow.com/questions/43380939/where-does-the-convention-of-using-healthz-for-application-health-checks-come-f I used alternative to etcd solution: consul; some other non-google things used simply /health endpoints as well. Speaking to k8s, would it make to switch from /healthz to /livez /readyz instead (not necessarily in this changelist, but maybe later on): https://kubernetes.io/docs/reference/using-api/health-checks/ ? That might be inline with the recent development that Abhishek in that area. Just as an extra note. -- To view, visit http://gerrit.cloudera.org:8080/17962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic735e210d95aeec1dfd1335ee972318f12d52475 Gerrit-Change-Number: 17962 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <zcho...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <zcho...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Oct 2021 19:18:33 +0000 Gerrit-HasComments: Yes
