[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17962 )
Change subject: KUDU-3308: Add health check endpoint to webserver ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG@9 PS1, Line 9: This change adds a '/healthz' endpoint to the kudu-master and : tablet-server webinterfaces. > It would be great if you added a small test for the newly introduced end-po you're right, I missed that this test exists, I'll amend it http://gerrit.cloudera.org:8080/#/c/17962/1//COMMIT_MSG@12 PS1, Line 12: As the Webserver only starts after the RPC : Server has been started there is no need to add an initial wait time for : the first check > I guess this is no longer true since https://github.com/apache/kudu/commit/ Yes, based on the commit msg there, moving it to "AddPostInitializedDefaultPathHandlers" should ensure that the RPC server is up and running. http://gerrit.cloudera.org:8080/#/c/17962/1/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/17962/1/src/kudu/server/default_path_handlers.cc@452 PS1, Line 452: is_styl > Kubernetes normally uses /healthz. Also, we have /varz and /memz too. What Attila said, and also the jira called for /healthz, but I'm fine with /health too. -- To view, visit http://gerrit.cloudera.org:8080/17962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic735e210d95aeec1dfd1335ee972318f12d52475 Gerrit-Change-Number: 17962 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Oct 2021 13:51:19 +0000 Gerrit-HasComments: Yes
