Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17974 )
Change subject: [encryption] KUDU-3331 Encrypt file system ...................................................................... Patch Set 7: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/17974/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17974/7//COMMIT_MSG@133 PS7, Line 133: I also wanted to run dense_node-itest with -num_seconds=240 and I guess you're saying it's based on a random workload so the results are also random. Maybe it's worth running the test with a limit on the number of rows instead of a timeout, changing the write pattern to sequential, and disabling compaction? http://gerrit.cloudera.org:8080/#/c/17974/7//COMMIT_MSG@134 PS7, Line 134: but the amount of data written (both in terms of : number of blocks and bytes), and nit: missing some words? http://gerrit.cloudera.org:8080/#/c/17974/7/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/17974/7/src/kudu/fs/log_block_manager-test.cc@a1173 PS7, Line 1173: : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : Was this removal intentional? -- To view, visit http://gerrit.cloudera.org:8080/17974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d0c4af0c1fca0d14c99a6627842dbe2ed7524 Gerrit-Change-Number: 17974 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 16 Nov 2021 20:33:44 +0000 Gerrit-HasComments: Yes
