Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )
Change subject: [tests] Add iteration to test dir path ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@159 PS3, Line 159: else { : VLOG(1) << "Cleaning up temporary test files..."; : WARN_NOT_OK(env_->DeleteRecursively(test_dir_), : "Couldn't remove test files"); : } > I'm surprised this wouldn't clean the directory. Is the same KuduTest reuse I guess it does, but not if there are fatal failures or if you always leave files, which can still be valuable if you want to compare files between successful and unsuccessful runs. -- To view, visit http://gerrit.cloudera.org:8080/18030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026 Gerrit-Change-Number: 18030 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 16 Nov 2021 19:15:58 +0000 Gerrit-HasComments: Yes
