Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )
Change subject: [tests] Add iteration to test dir path ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@159 PS3, Line 159: else { : VLOG(1) << "Cleaning up temporary test files..."; : WARN_NOT_OK(env_->DeleteRecursively(test_dir_), : "Couldn't remove test files"); : } > I guess it does, but not if there are fatal failures or if you always leave IIUC, a new instance of KuduTest is created for each iteration. Otherwise, using test_dir_ and GetTestDataDirectory() would result in unexpected inconsistencies. However, if --test_leave_files is set or a test fails sometimes, the directory isn't removed. Not a big deal if running the test interactively, but if thinking about scheduling a run using --gtest_repeat, the newly introduced functionality comes handy. -- To view, visit http://gerrit.cloudera.org:8080/18030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026 Gerrit-Change-Number: 18030 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 16 Nov 2021 19:40:59 +0000 Gerrit-HasComments: Yes
