Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18030 )
Change subject: [tests] Add iteration to test dir path ...................................................................... [tests] Add iteration to test dir path GTest supports running tests repeatedly by setting a "--gtest_repeat" flag, which can be incredibly useful to debug flaky tests when using together with "--gtest_break_on_failure" in gdb. Unfortunately, most of our tests expect an empty data directory, but the test directory was the same across repeated runs without being emptied. Adding the iteration number to the end of the directory solves this problem and --gtest_repeat can be used safely. Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026 Reviewed-on: http://gerrit.cloudera.org:8080/18030 Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Attila Bukor <[email protected]> --- M src/kudu/util/test_main.cc M src/kudu/util/test_util.cc M src/kudu/util/test_util.h 3 files changed, 22 insertions(+), 6 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Alexey Serbin: Looks good to me, approved Attila Bukor: Verified -- To view, visit http://gerrit.cloudera.org:8080/18030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026 Gerrit-Change-Number: 18030 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
