Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18049 )
Change subject: Fix readlink behaviour on MacOS in start_kudu.sh ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18049/1/src/kudu/scripts/start_kudu.sh File src/kudu/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/18049/1/src/kudu/scripts/start_kudu.sh@78 PS1, Line 78: echo $(readlink -f $(dirname $0)) looks like this readlink never actually did anything useful, other than throw a warning on macos. It seems it originates here: https://gerrit.cloudera.org/c/14192/6/examples/quickstart/scripts/start_kudu.sh. While you're at it, can you make sure the result in both OSs is used as intended? -- To view, visit http://gerrit.cloudera.org:8080/18049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0057a6d6668488001be8b4f74f46010e2620b46e Gerrit-Change-Number: 18049 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Nov 2021 14:57:48 +0000 Gerrit-HasComments: Yes
