Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18049 )
Change subject: Fix readlink behaviour on MacOS in start_kudu.sh ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18049/1/src/kudu/scripts/start_kudu.sh File src/kudu/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/18049/1/src/kudu/scripts/start_kudu.sh@78 PS1, Line 78: echo $(readlink -f $(dirname $0)) > Yup, indeed that seemed to be used just for informational purposes as of la I think we would only need the realpath if we are running the script from a different directory (so not kudu/scripts/) and we do not provide a -b/--builddir parameter. In that case $BUILDDIR will be $PWD and WEBSERVER_DOC_ROOT, KUDUMASTER, KUDUTSERVER variable will point to the wrong place and the startup will fail with a "Cannot find webroot directory" error. Maybe we could make this more clear in the help text for the -b param and remove the readlink line? -- To view, visit http://gerrit.cloudera.org:8080/18049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0057a6d6668488001be8b4f74f46010e2620b46e Gerrit-Change-Number: 18049 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 24 Nov 2021 17:40:59 +0000 Gerrit-HasComments: Yes
