Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18049 )
Change subject: Fix readlink behaviour on MacOS in start_kudu.sh ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18049/1/src/kudu/scripts/start_kudu.sh File src/kudu/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/18049/1/src/kudu/scripts/start_kudu.sh@78 PS1, Line 78: echo $(readlink -f $(dirname $0)) > It seems it's assumed to run the script from the build directory if not pro @Alexey Yes, it makes sense, I've updated this change to reflect what you've described. The only thing that is not clear to me is what happens when the --webserver_doc_root flag is not set for kudu-master and kudu-tserver. Doesn't that mean that the static pages can't load on the webui? In that case isn't the whole webui part kind of useless? -- To view, visit http://gerrit.cloudera.org:8080/18049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0057a6d6668488001be8b4f74f46010e2620b46e Gerrit-Change-Number: 18049 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 29 Nov 2021 14:28:07 +0000 Gerrit-HasComments: Yes
