Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18081 )
Change subject: [consensus] minor clean-up on LogCache ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18081/1/src/kudu/consensus/log_cache.h File src/kudu/consensus/log_cache.h: http://gerrit.cloudera.org:8080/#/c/18081/1/src/kudu/consensus/log_cache.h@176 PS1, Line 176: LogPrefixUnlocked > nit: why is this called *Unlocked? Do we need to hold a lock while calling It seems that came from other consensus-related places where it's necessary to capture some dynamic information when producing the prefix. The methods named LogPrefixUnlocked() is used in the VLOG_WITH_PREFIX_UNLOCKED and LOG_WITH_PREFIX_UNLOCKED macros. I guess we might do revise them, but it would be a separate patch to address that anyways. http://gerrit.cloudera.org:8080/#/c/18081/1/src/kudu/consensus/log_cache.cc File src/kudu/consensus/log_cache.cc: http://gerrit.cloudera.org:8080/#/c/18081/1/src/kudu/consensus/log_cache.cc@89 PS1, Line 89: log_prefix_(Substitute("T $0 P $1: ", tablet_id_, local_uuid_)), > Looking around a bit, it seems like the log prefix is mostly logged in warn Good point! I wasn't exactly sure about adding log_prefix_, but after taking a second look I removed this new member. -- To view, visit http://gerrit.cloudera.org:8080/18081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f60c44209e269eb6b00278c6e32d4398ef9a55 Gerrit-Change-Number: 18081 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Dec 2021 17:59:18 +0000 Gerrit-HasComments: Yes
