Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18081 )
Change subject: [consensus] minor clean-up on LogCache
......................................................................
[consensus] minor clean-up on LogCache
Since I was looking a bit into the code of the LogCache cache,
I went ahead and did a minor clean-up here, such as
* removing unused code
* fixing code style
* simplifying the going-over-max_size_bytes condition in ReadOps(),
making sure the regression test for KUDU-1586 passes
* fixing signed/unsigned comparison warning for a Raft op's index and
the index of the corresponding entry in the cache
* other unsorted minor updates
Change-Id: I48f60c44209e269eb6b00278c6e32d4398ef9a55
Reviewed-on: http://gerrit.cloudera.org:8080/18081
Reviewed-by: Andrew Wong <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
---
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
2 files changed, 46 insertions(+), 58 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I48f60c44209e269eb6b00278c6e32d4398ef9a55
Gerrit-Change-Number: 18081
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
