Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18081 )
Change subject: [consensus] minor clean-up on LogCache ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18081/1/src/kudu/consensus/log_cache.h File src/kudu/consensus/log_cache.h: http://gerrit.cloudera.org:8080/#/c/18081/1/src/kudu/consensus/log_cache.h@176 PS1, Line 176: ixUnlocked() cons > It seems that came from other consensus-related places where it's necessary Ah I see, SGTM. I'm fine with leaving these as is then, thanks for clarifying! -- To view, visit http://gerrit.cloudera.org:8080/18081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f60c44209e269eb6b00278c6e32d4398ef9a55 Gerrit-Change-Number: 18081 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Dec 2021 19:30:50 +0000 Gerrit-HasComments: Yes
