Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18098 )
Change subject: KUDU-3197 [tserver] optimal Schema's memory used ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18098/4//COMMIT_MSG Commit Message: PS4: Started looking briefly into this, but it seems like a lot of the test-only and client-side usages of Schemas were fine as is. I think we should limit the scope of this change to only worry about the Schemas in old_schemas_ in TabletMetadata, since that's what was consuming memory in KUDU-3197. http://gerrit.cloudera.org:8080/#/c/18098/4/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/18098/4/src/kudu/client/schema.h@732 PS4, Line 732: /// Convert a KuduSchema to a Schema. : /// : /// Private API. : /// : /// @param[in] kudu_schema : /// The KuduSchema to convert : /// @return The converted Schema : static scoped_refptr<Schema> ToSchema(const KuduSchema& kudu_schema) KUDU_NO_EXPORT; This change doesn't seem necessary to address KUDU-3197 -- To view, visit http://gerrit.cloudera.org:8080/18098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9cf24475de0b787542761522915a86db6564d7 Gerrit-Change-Number: 18098 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Dec 2021 20:35:13 +0000 Gerrit-HasComments: Yes
