Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18098 )
Change subject: KUDU-3197 [tserver] optimal Schema's memory used ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18098/4/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/18098/4/src/kudu/client/schema.h@732 PS4, Line 732: /// Convert a KuduSchema to a Schema. : /// : /// Private API. : /// : /// @param[in] kudu_schema : /// The KuduSchema to convert : /// @return The converted Schema : static scoped_refptr<Schema> ToSchema(const KuduSchema& kudu_schema) KUDU_NO_EXPORT; > This change doesn't seem necessary to address KUDU-3197 Now class Schema is inherited from RefCountedThreadSafe<Schema>, constructor has been declared as 'delete', so we can't create such a Schema object after this patch, and that's why you can see so many changes, we can reduce changes by using std::shared_ptr, but that seems not the recommanded smart pointer in Kudu. -- To view, visit http://gerrit.cloudera.org:8080/18098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9cf24475de0b787542761522915a86db6564d7 Gerrit-Change-Number: 18098 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 19 Dec 2021 14:49:53 +0000 Gerrit-HasComments: Yes
