Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18098 )
Change subject: KUDU-3197 [tserver] optimal Schema's memory used ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18098/4/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/18098/4/src/kudu/client/schema.h@732 PS4, Line 732: /// Convert a KuduSchema to a Schema. : /// : /// Private API. : /// : /// @param[in] kudu_schema : /// The KuduSchema to convert : /// @return The converted Schema : static scoped_refptr<Schema> ToSchema(const KuduSchema& kudu_schema) KUDU_NO_EXPORT; > +1 Just to clarify on my earlier comment: using std::shared_ptr instead of scoped_refptr is a good alternative. However, changing the return type of the KuduSchema::ToSchema(const KuduSchema&) method would break the ABI compatibility for Kudu C++ client, so this particular update isn't acceptable. See https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B for details on the ABI compatibility. -- To view, visit http://gerrit.cloudera.org:8080/18098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9cf24475de0b787542761522915a86db6564d7 Gerrit-Change-Number: 18098 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 22 Dec 2021 18:04:15 +0000 Gerrit-HasComments: Yes
