Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode ...................................................................... Patch Set 1: (1 comment) Overall I think this looks good. Just left some thoughts on overall approach, but I'm leaning to keeping the behavior as implemented in this patch. Curious if you've given thought to including maintenance mode tservers to the ignored list automatically. http://gerrit.cloudera.org:8080/#/c/18074/1//COMMIT_MSG Commit Message: PS1: This makes sense because typically maintenance would be used for the sake of a rolling restart, and if the cluster is being restarted, we may not want to be rebalancing, given maintenance mode may shift to another node soon. Another thought I had was that perhaps we should automatically include maintenance tservers in the list of ignored tservers, though I haven't given it enough thought to decide whether that's a good decision or not. I'd err on the side of ensuring it's clear what the rebalancer is doing, and automatically omitting certain tservers doesn't abide by that principle.. -- To view, visit http://gerrit.cloudera.org:8080/18074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b Gerrit-Change-Number: 18074 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Dec 2021 20:49:23 +0000 Gerrit-HasComments: Yes
