Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode ...................................................................... Patch Set 3: Verified+1 (5 comments) Thank you for the improvement! A few questions and nits. http://gerrit.cloudera.org:8080/#/c/18074/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18074/3//COMMIT_MSG@15 PS3, Line 15: It would be great to add small blurb to explain the target use case for this improvement. http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.h File src/kudu/tools/rebalancer_tool.h: http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.h@100 PS3, Line 100: tablets server nit: tablet servers http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.cc@763 PS3, Line 763: server nit: maybe, use 'tserver' here as well since it's referred to as 'tserver' at item 3. http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc@156 PS3, Line 156: force_rebalance_replicas_on_maintenance_tservers It would be nice to clarify on the behavior of the tool if the following are true: * a tserver in the maintenance mode * the tserver is in the --ingnored_tservers list * --force_rebalance_replicas_on_maintenance_tservers is also specified What does the tool do with the replicas at that tserver? http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc@159 PS3, Line 159: would be ignored Any adverse effects when doing so? For example, what happens if a tablet server in the maintenance mode is currently down? Does it make sense to mention some caveats like that to help an operator who runs the rebalancer tool? -- To view, visit http://gerrit.cloudera.org:8080/18074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b Gerrit-Change-Number: 18074 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:53:50 +0000 Gerrit-HasComments: Yes
