Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) > > Overall I think this looks good. Just left some thoughts on overall approach, > but I'm leaning to keeping the behavior as implemented in this patch. > > Curious if you've given thought to including maintenance mode tservers to the > ignored list automatically. http://gerrit.cloudera.org:8080/#/c/18074/1//COMMIT_MSG Commit Message: PS1: > This makes sense because typically maintenance would be used for the sake o Yes, I've thought about just ignoring the maintenance mode servers. The concern is that we don't know whether users really wants to continue rebalancing in the case, return an error seems doesn't affect anything, if they want to rebalance replicas on the other servers, they could ignore maintenance servers manually. -- To view, visit http://gerrit.cloudera.org:8080/18074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b Gerrit-Change-Number: 18074 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 15 Dec 2021 06:57:34 +0000 Gerrit-HasComments: Yes
