Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18159 )
Change subject: [java] Upgrade dependencies ...................................................................... Patch Set 7: (2 comments) It seems Java LINT isn't yet happy, complaining about META-INF/services/reactor.blockhound.integration.BlockHoundIntegration: http://jenkins.kudu.apache.org/job/kudu-gerrit/24974/BUILD_TYPE=LINT/console http://gerrit.cloudera.org:8080/#/c/18159/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18159/7//COMMIT_MSG@42 PS7, Line 42: 30.1.-jre -> 31.0.1-jre This looks rather like a downgrade :) BTW, I didn't find guava version changed in gradle files in PS7 -- is it missing somehow? http://gerrit.cloudera.org:8080/#/c/18159/7/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/18159/7/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@142 PS7, Line 142: val pool = new ForkJoinPool(options.numParallelBackups) // Need a clean-up reference. Since no clean-up is needed per https://gerrit.cloudera.org/#/c/18159/6/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@a157, maybe it's time to drop the 'pool' variable and join create the pool in-place as an argument for ForkJoinTaskSupport() below? -- To view, visit http://gerrit.cloudera.org:8080/18159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I300af97556a8c12a2e7c0deb2ae723c2ea639518 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 20 Jan 2022 16:35:56 +0000 Gerrit-HasComments: Yes
