Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18159 )
Change subject: [java] Upgrade dependencies ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18159/6/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/18159/6/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@a157 PS6, Line 157: > according to the docs this will be shut down automatically on exit, and cal BTW, does the newly updated code still works fine with Spark 2 (if it have to run with that version at all)? It would be great to clarify -- I guess adding explicit call to shutdown() was not just a random thing. -- To view, visit http://gerrit.cloudera.org:8080/18159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I300af97556a8c12a2e7c0deb2ae723c2ea639518 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Jan 2022 06:01:17 +0000 Gerrit-HasComments: Yes
