Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18124 )
Change subject: KUDU-2915: add tool to unregister a tablet server ...................................................................... Patch Set 6: (1 comment) > Patch Set 6: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master_service.cc@355 PS5, Line 355: rpc->RespondFailure(s); : return; : } : } : : Status s = server_->ts_manager()->UnregisterTServer(ts_uuid, force_unregister_live_tserver); : if (PREDICT_FALSE(!s.ok() && !s.IsNotFound())) { : // Ignore the NotFound error to make this RPC retriable and effectively idempotent. : rpc->RespondFailure(s); : > Another thought to consider: perhaps we should consider separating this int I think separating this into two RPCs should be a good way. -- To view, visit http://gerrit.cloudera.org:8080/18124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f5c2979a8d14428f4bcc8e850c57ce228c793a Gerrit-Change-Number: 18124 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 21 Jan 2022 03:31:59 +0000 Gerrit-HasComments: Yes
