Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18124 )
Change subject: KUDU-2915: add tool to remove a tablet server ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/18124/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18124/3//COMMIT_MSG@14 PS3, Line 14: a ( > nit: missing space Done http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/master/ts_manager.cc@321 PS3, Line 321: shared_ptr<TSDescriptor> ts_desc; > I was a bit concerned that there'd be a TOCTOU here, since we take the lock Done http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/tools/kudu-tool-test.cc@7561 PS3, Line 7561: > nit: after this, can we also verify that the ksck output still shows the ts Done http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/tools/tool_action_tserver.cc@61 PS3, Line 61: force the removal of the tserver " : "even if it is considered live > nit: how about "If true, force the removal of the tserver, even if it is co Done http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/tools/tool_action_tserver.cc@64 PS3, Line 64: "in-memory map but keep its persisted state (if any). If the same tserver re-re > nit: "If the same tserver re-registers on the..." Done http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/tools/tool_action_tserver.cc@64 PS3, Line 64: ste > nit: add a space Done http://gerrit.cloudera.org:8080/#/c/18124/3/src/kudu/tools/tool_action_tserver.cc@323 PS3, Line 323: RETURN_NOT_OK(proxy->RemoveTabletServer(req, &resp, &rpc)); : if (resp.has_error()) { : > Have you considered running the RPC on all masters, and then collecting err Done. If a master is down, we get errors in previous `VerifyMasterAddressList`, but logging error messages is useful. -- To view, visit http://gerrit.cloudera.org:8080/18124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f5c2979a8d14428f4bcc8e850c57ce228c793a Gerrit-Change-Number: 18124 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 18 Jan 2022 14:03:55 +0000 Gerrit-HasComments: Yes
