Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18124 )
Change subject: KUDU-2915: add tool to unregister a tablet server ...................................................................... Patch Set 6: (12 comments) http://gerrit.cloudera.org:8080/#/c/18124/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18124/5//COMMIT_MSG@9 PS5, Line 9: kudu tserver unregi > Should we call this 'kudu tserver unregister' instead? From what I can see Done http://gerrit.cloudera.org:8080/#/c/18124/5//COMMIT_MSG@11 PS5, Line 11: restart > nit: restarting Done http://gerrit.cloudera.org:8080/#/c/18124/5//COMMIT_MSG@13 PS5, Line 13: removes the > nit: removes Done http://gerrit.cloudera.org:8080/#/c/18124/5//COMMIT_MSG@14 PS5, Line 14: le to unregister a tserver > nit: It's also possible to remove ... Done http://gerrit.cloudera.org:8080/#/c/18124/5//COMMIT_MSG@15 PS5, Line 15: tserver', and keep : tserver's persiste > nit: instead of referring those as 'some', maybe specify the exact names of Done http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master.proto@1074 PS5, Line 1074: persisted cata > nit: persistent catalog Done http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master.proto@1076 PS5, Line 1076: // The tserver UUID to be > nit: even if it seems self-obvious, it would be nice to add a comment for t Done http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master.proto@1080 PS5, Line 1080: // For this to take effect, the receiv > I'm curious if it makes sense to enable this by default? Could you add an Done http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master_service.cc@341 PS5, Line 341: can c > nit: could --> can (for simplicity, keep the same tense in the sentence: ht Done http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master_service.cc@351 PS5, Line 351: > If following the comment above, this should be RespondSuccess(), shouldn't This is in the condition where the status is not 'NotFound' so it should be RespondFailure. http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/master_service.cc@355 PS5, Line 355: rpc->RespondFailure(s); : return; : } : } : : Status s = server_->ts_manager()->UnregisterTServer(ts_uuid, force_unregister_live_tserver); : if (PREDICT_FALSE(!s.ok() && !s.IsNotFound())) { : // Ignore the NotFound error to make this RPC retriable and effectively idempotent. : rpc->RespondFailure(s); : > Shouldn't we first try removing tserver's state record? Are the system cat Done http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/18124/5/src/kudu/master/ts_manager.cc@328 PS5, Line 328: erver $0 is not presumed de > I'm not sure this is exactly relevant in the error message from the server Done -- To view, visit http://gerrit.cloudera.org:8080/18124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f5c2979a8d14428f4bcc8e850c57ce228c793a Gerrit-Change-Number: 18124 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 19 Jan 2022 11:05:38 +0000 Gerrit-HasComments: Yes
