Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h File src/kudu/security/kinit_context.h: http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@68 PS7, Line 68: // Periodically calls DoRenewal(). nit: private is OK http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86 PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(500)); Why increase it? -- To view, visit http://gerrit.cloudera.org:8080/18135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691 Gerrit-Change-Number: 18135 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 28 Jan 2022 16:23:27 +0000 Gerrit-HasComments: Yes
