Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h File src/kudu/security/kinit_context.h: http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@45 PS7, Line 45: Ticket Gr > renewal thread Done http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@45 PS7, Line 45: icket > nit: delte --> destroying yes. In security-itest.cc, a KinitContext be instantiated on the stack http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@46 PS7, Line 46: // > Maybe, make this method private and call it in the destructor? Done http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@68 PS7, Line 68: // Safe stop the renewal thread before destroying KinitContext > nit: private is OK Done http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@90 PS7, Line 90: : // To stop reacquire_thread_ when proces > Add comments for this two fields: what are they for, what's the relation be Done http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86 PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(500)); > Why increase it? In my tests, the case is a little not stable. -- To view, visit http://gerrit.cloudera.org:8080/18135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691 Gerrit-Change-Number: 18135 Gerrit-PatchSet: 8 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 30 Jan 2022 07:15:48 +0000 Gerrit-HasComments: Yes
