Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc@321 PS9, Line 321: Status It seems the return type for this method can be changed from Status to void? http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc@323 PS9, Line 323: scoped_refptr<Thread> t = reacquire_thread_; : if (t.get() != nullptr) { : t->Join(); : } Why not to use the existing 'reacquire_thread_' handle to do this? Please add a comment to explain if there is any particular reason. http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc@520 PS9, Line 520: Status Does it make sense to update the signature of this method to return void instead of Status? http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/kinit_context.h File src/kudu/security/kinit_context.h: http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/kinit_context.h@93 PS9, Line 93: thread for do renewals kerberos nit: how about A thread to renew and reacquire Kerberos credentials. ? http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86 PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(200)); > ok. I have restore it. Thank you! If you still see the instability because of this, feel free to post a separate patch to address the issue. -- To view, visit http://gerrit.cloudera.org:8080/18135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691 Gerrit-Change-Number: 18135 Gerrit-PatchSet: 9 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 31 Jan 2022 00:43:26 +0000 Gerrit-HasComments: Yes
