Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18025 )
Change subject: [security] KUDU-3316 Add encrypted file keys ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/18025/17/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/18025/17/src/kudu/util/env_posix.cc@849 PS17, Line 849: (key_size + 15) & -16) > Well, and actually BitUtil::Ceil() does a different thing: it divides the n BitUtil::Ceil() was pretty close to my original approach without having to use doubles, so it would've been an optimization. I think my current approach only works for powers of 2, so it wouldn't help with a general approach like Ceil() anyway. -- To view, visit http://gerrit.cloudera.org:8080/18025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb1282c117271fda63a8cc54c00add7cc96dcffd Gerrit-Change-Number: 18025 Gerrit-PatchSet: 18 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sun, 30 Jan 2022 13:25:34 +0000 Gerrit-HasComments: Yes
