Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18025 )
Change subject: [security] KUDU-3316 Add encrypted file keys ...................................................................... Patch Set 17: Code-Review+2 (1 comment) Overall looks good to me! It's worth it checking if Andrew has some extra feedback. http://gerrit.cloudera.org:8080/#/c/18025/17/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/18025/17/src/kudu/fs/log_block_manager.cc@749 PS17, Line 749: auto encryption_header_size = data_file_->GetEncryptionHeaderSize(); : // If we have an encryption header, we need to align the next offset to the : // next file system block. : if (encryption_header_size > 0) { nit: since it's C++17 code, it's possible to put the related variable under 'if ()' clause as well: you can see https://github.com/apache/kudu/blob/c2e3efdcefd1de65d805749ba3198adfe9dba79d/src/kudu/client/client.cc#L1793-L1798 as an example and https://en.cppreference.com/w/cpp/language/if for the reference (check the 'init-statement' part) -- To view, visit http://gerrit.cloudera.org:8080/18025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb1282c117271fda63a8cc54c00add7cc96dcffd Gerrit-Change-Number: 18025 Gerrit-PatchSet: 17 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 29 Jan 2022 21:31:11 +0000 Gerrit-HasComments: Yes
