Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18025 )
Change subject: [security] KUDU-3316 Add encrypted file keys ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/18025/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18025/14//COMMIT_MSG@33 PS14, Line 33: With encryption enabled, extra : steps are necessary to align the first block, and aligning blocks makes : it impractical to hide encryption header size within Env and use : logical file sizes outside of it. > Sure. I'm curious though, is the LBM the main part that would be complicate I didn't go through every failure, but both LBM and log seemed to be more complicated than initially expected. In LBM, there was some weirdness that I couldn't figure yet figure out causing most of the tests fail, and in log, it wasn't only reading the footer where the offset had to be calculated using the size, but there's also the read_up_to, which is used when reading entries without a footer. Even after adjusting this, there were still corruption failures in most tests. I'm sure it would be possible to fix all of these, but based on how many changes I had to do, it wouldn't really make a difference in the complexity. I guess it's just that no one has foreseen that there could be differences in how size and offsets are being calculated. -- To view, visit http://gerrit.cloudera.org:8080/18025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb1282c117271fda63a8cc54c00add7cc96dcffd Gerrit-Change-Number: 18025 Gerrit-PatchSet: 16 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 29 Jan 2022 08:21:29 +0000 Gerrit-HasComments: Yes
