yejiabao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18152 )
Change subject: KUDU-3344: catalog manager clean up metadata for deleted tables/tablets ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.cc@5584 PS4, Line 5584: tablets_lock.Lock(LockMode::WRITE); nit:why use the LockMode::WRITE when the 'tablets' is not written? http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.cc@5621 PS4, Line 5621: tables_lock.Lock(LockMode::WRITE); nit:why use the LockMode::WRITE when the 'tables' is not written? -- To view, visit http://gerrit.cloudera.org:8080/18152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idefa2ee2f5108ba913fe0057a4061c3c28351547 Gerrit-Change-Number: 18152 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Thu, 10 Feb 2022 11:49:42 +0000 Gerrit-HasComments: Yes
