Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18152 )
Change subject: KUDU-3344: catalog manager clean up metadata for deleted tables/tablets ...................................................................... Patch Set 5: Verified+1 (1 comment) unrelated test failure in DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.cc@5208 PS4, Line 5208: TableMetadataLock table_lock(tablet->table().get(), LockMode::READ); : TabletMetadataLock tablet_lock(tablet.get(), LockMode::READ); > Done. But just obtaining READ locks may not leads to a deadlock. Ah, indeed -- those are READ locks as well in ExtractTabletsToProcess(). Anyways, it should work as they are re-ordered now in PS5 :) Thank you! -- To view, visit http://gerrit.cloudera.org:8080/18152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idefa2ee2f5108ba913fe0057a4061c3c28351547 Gerrit-Change-Number: 18152 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Sun, 20 Feb 2022 19:33:25 +0000 Gerrit-HasComments: Yes
