Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18152 )
Change subject: KUDU-3344: catalog manager clean up metadata for deleted tables/tablets ...................................................................... Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/integration-tests/master-stress-test.cc@161 PS4, Line 161: } > Is this still needed? Done http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@764 PS4, Line 764: es(&table_in > nit: could this ever generate a gtest-related error? If not, then maybe re Done http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.h@775 PS4, Line 775: the catalog > nit: if this is a test-only method, maybe name it GetAllTabletsForTests() ? Done http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.h@1045 PS4, Line 1045: void ExtractTabletsToProcess(std::vector<scoped_refptr<TabletInfo>>* tablets_to_process); > nit: do you mind adding a small comment for this method as for the rest one Done http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.h@1139 PS4, Line 1139: : void ResetTableLocationsCache(); : : // Task that takes care of deleted tables, is called in > nit: it's sort of self-obvious, but would be nice to add a few words to des Done http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/catalog_manager.cc@5208 PS4, Line 5208: TableMetadataLock table_lock(tablet->table().get(), LockMode::READ); : TabletMetadataLock tablet_lock(tablet.get(), LockMode::READ); > Should the order of taking locks be reversed here? At least in ExtractTabl Done. But just obtaining READ locks may not leads to a deadlock. http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/master-test.cc@2403 PS4, Line 2403: master_-> > nit here and below: could GetAllTables() generate any gtest error? If not, Done http://gerrit.cloudera.org:8080/#/c/18152/4/src/kudu/master/master-test.cc@2576 PS4, Line 2576: constexpr const char* > nit: this might be Done -- To view, visit http://gerrit.cloudera.org:8080/18152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idefa2ee2f5108ba913fe0057a4061c3c28351547 Gerrit-Change-Number: 18152 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Fri, 18 Feb 2022 14:09:04 +0000 Gerrit-HasComments: Yes
