Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18152 )
Change subject: KUDU-3344: catalog manager clean up metadata for deleted tables/tablets ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18152/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18152/6/src/kudu/master/catalog_manager.cc@393 PS6, Line 393: enable_chunked_tablet_writes, > Thanks for the correction! It sounds good, but we need to preserve backward compatibility. Simply replacing the 'catalog_manager_enable_chunked_tablet_reports' flag with 'enable_chuncked_tablet_writes' doesn't look like the best path forward. Ideally, there should be deprecation period for the 'catalog_manager_enable_chunked_tablet_reports' if we want to replace it. Anyways, if doing so, it's better to perform that change in a separate patch/changelist anyways -- that's out of the scope of this patch. -- To view, visit http://gerrit.cloudera.org:8080/18152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idefa2ee2f5108ba913fe0057a4061c3c28351547 Gerrit-Change-Number: 18152 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Mon, 21 Feb 2022 18:22:28 +0000 Gerrit-HasComments: Yes
