Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18258 )
Change subject: [metrics] Add table level metrics column_count and schema_version on master ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18258/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18258/4/src/kudu/master/catalog_manager.cc@6669 PS4, Line 6669: { : TableMetadataLock l(this, LockMode::READ); : const SysTablesEntryPB& pb = metadata().state().pb; : metrics_->column_count->set_value(pb.schema().columns().size()); : metrics_->schema_version->set_value(pb.version()); : } Seems we update these two metrics every time we process tablets' report from tservers, which is a bit weird. What do you think of updating them as needed when processing DDL requests? -- To view, visit http://gerrit.cloudera.org:8080/18258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0671cfb0758d53e950a4e35a968dae15f82d18e Gerrit-Change-Number: 18258 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 11 Mar 2022 10:48:05 +0000 Gerrit-HasComments: Yes
