Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18258 )
Change subject: [metrics] Add table level metrics column_count and schema_version on master ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18258/8/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/18258/8/src/kudu/master/catalog_manager.h@369 PS8, Line 369: UpdateSchemaMetrics My another thought is these schema related metrics are really 'metrics' or just 'attributes' of a MetricEntity? I think attributes can also be exposed to monitoring systems. Maybe num_schema_changes is more like a metric. -- To view, visit http://gerrit.cloudera.org:8080/18258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0671cfb0758d53e950a4e35a968dae15f82d18e Gerrit-Change-Number: 18258 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 12 Mar 2022 07:15:59 +0000 Gerrit-HasComments: Yes
