Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18258 )

Change subject: [metrics] Add table level metrics column_count and 
schema_version on master
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18258/4/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18258/4/src/kudu/master/catalog_manager.cc@6669
PS4, Line 6669:       }
              :         
metrics_->live_row_count->set_value(static_cast<int64_t>(live_row_count));
              :       }
              :     }
              :   }
              : }
> Seems we update these two metrics every time we process tablets' report fro
Good suggestion, done.



--
To view, visit http://gerrit.cloudera.org:8080/18258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0671cfb0758d53e950a4e35a968dae15f82d18e
Gerrit-Change-Number: 18258
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Fri, 11 Mar 2022 16:50:42 +0000
Gerrit-HasComments: Yes

Reply via email to