Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18330 )
Change subject: [tool] Fix pbc dump instance for -json/ -json_pretty ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18330/4/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: http://gerrit.cloudera.org:8080/#/c/18330/4/src/kudu/util/pb_util.cc@1039 PS4, Line 1039: } : } : } : } : nit: There are too many indent levels, you can use 'inverted if and short-circuit break' to optimize it. E.g. if (is_edit) { break; } ... if (!xxx.ok()) { break; } ... -- To view, visit http://gerrit.cloudera.org:8080/18330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21afb03d9b7b4b2d4ea5aaa642701451282bebf Gerrit-Change-Number: 18330 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 06 Apr 2022 08:31:20 +0000 Gerrit-HasComments: Yes
