Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18330 )
Change subject: [tool] Fix pbc dump instance for -json/ -json_pretty ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18330/4/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: http://gerrit.cloudera.org:8080/#/c/18330/4/src/kudu/tools/tool_action_pbc.cc@210 PS4, Line 210: RETURN_NOT_OK(pb_reader.Dump(&stream, format, > I'm not sure that all pbc files have the 'uuid' field, so I think make deco It's a special fix. The most appropriate fix is pb decode with base64, but not support. Now there are 2 named uuid which type is bytes, they are InstancePB and DirSetPB, so the fix is ok, but indeed not good. And considing seperate the special decode pb is a good idea, but produce some repetitive codes. I'll think it again. -- To view, visit http://gerrit.cloudera.org:8080/18330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21afb03d9b7b4b2d4ea5aaa642701451282bebf Gerrit-Change-Number: 18330 Gerrit-PatchSet: 7 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 27 Apr 2022 02:44:00 +0000 Gerrit-HasComments: Yes
